kubewarden / helm-charts

Helm charts for the Kubewarden project
Apache License 2.0
25 stars 16 forks source link

fix: Disable logs tab on policy-reporter UI #365

Closed viccuad closed 8 months ago

viccuad commented 8 months ago

Description

The Policy Reporter UI logs tab shows logs for enabled targets. Possible targets: https://kyverno.github.io/policy-reporter/core/targets/

This is configured by enabling the logs view, and setting policy-reporter.ui.sources[] value.

The log tab will be empty by default though, which can be disorienting. Disabling it.

Test

Tested locally.

Additional Information

Tradeoff

Potential improvement

flavio commented 8 months ago

Does the concept of target have an equivalent in the Kubewarden "world'? If there's an equivalent, I think it would be better to document how to use that and be explicit about why the logs are empty instead of hiding them.

jvanz commented 8 months ago

Does the concept of target have an equivalent in the Kubewarden "world'? If there's an equivalent, I think it would be better to document how to use that and be explicit about why the logs are empty instead of hiding them.

As far as I can see, there is not. What I understand reading the policy reporter docs, is that targets are services that users can send the report to notify then when new results are available. I do not think we have something similar. In fact, we are using the policy reporter to give more visibility about the result to the users. Therefore, unless we want to document how to use targets, I'm fine by disabling the logs and documented it why we are doing that. In the end, users can re-enabled it if they configure some target for the policy reporter.

viccuad commented 8 months ago

I share the same view as @jvanz.

@jordojordo, does the UI take this change for disabling the log tab when deploying Kubewarden, or is something that needs to be ported there too?

flavio commented 8 months ago

We all agree this can be hidden