search

kubewarden / helm-charts

Helm charts for the Kubewarden project
Apache License 2.0
25 stars 16 forks source link

Prevent Policy Server Crash in case of a maintenance in Kubernetes Nodepools #383

Closed ferhatguneri closed 7 months ago

ferhatguneri commented 7 months ago

Description

If policy server crash because of wrong clusteradmissionpolicy it is blocking pod to be created and cannot evaluate resources correctly. which is affecting control plane. therefore need to keep policy-server always available. These changes also can be added to policy server deployment but since it is hardcoded with Go, I thought of editing the helm chart.

flavio commented 7 months ago

Thanks for the contribution. This fixes only the PolicyServer named default. The proper fix should be done inside of the kubewarden-controller. This is tracked with https://github.com/kubewarden/kubewarden-controller/issues/564

flavio commented 7 months ago

Yes, that would be great. Take a look at https://github.com/kubewarden/kubewarden-controller/issues/564#issuecomment-1781175791 and implement the "Pod Disruption Budget" section.

Feel free to reach out if something is not clear or if you need help

ferhatguneri commented 7 months ago

Hi @flavio I'm aware of that issue but there is no progress since long time. This is a very critical problem and I believe it needs to be fixed immediately. Do you have any idea how long it will take to get it fixed? It is not really good idea to patch these helm charts internally and deal with the upcoming changes.

flavio commented 7 months ago

I think we can start working on this fix during the next sprint and make it part of the 1.11 release, but I have to discuss that with the other maintainers.

flavio commented 7 months ago

Closing, we will fix that inside of the controller with https://github.com/kubewarden/kubewarden-controller/issues/564