kubewarden / helm-charts

Helm charts for the Kubewarden project
Apache License 2.0
25 stars 16 forks source link

ci: Add UI inputs for `Update helm charts` job, refactor and drop need for `crds_asset_id` #400

Closed viccuad closed 5 months ago

viccuad commented 5 months ago

Description

Fix https://github.com/kubewarden/helm-charts/issues/307

Changes:

image

Test

Major/minor release update run: https://github.com/viccuad/helm-charts/actions/runs/8263364335 Patch release update run: https://github.com/viccuad/helm-charts/actions/runs/8263508789/job/22605107087

Also, tested updatecli/scripts/install_crds.sh locally, with various /tmp/crds-{controller,audit-scanner}.tar.gz.

Additional Information

Tradeoff

Potential improvement

I don't like the added complexity created by adding the workflow_dispatch inputs, and needing to pass it to the js scripts via GH env vars, but it is what it is.

About the refactors, I'm happy splitting the commits in several PRs. I tested it altogether to save time. If they aren't wanted they can be dropped, or we can go with https://github.com/kubewarden/helm-charts/pull/399.

viccuad commented 5 months ago

Updated input fields from review:

Screenshot_2024-03-13_18-34-23