kubewarden / helm-charts

Helm charts for the Kubewarden project
Apache License 2.0
25 stars 16 forks source link

feat: Add HA settings to Rancher UI questions #425

Closed viccuad closed 4 months ago

viccuad commented 4 months ago

Description

partially closes https://github.com/kubewarden/helm-charts/issues/418 (some features are blocked by UI bugs, see below).

Test

Tested manually. See videos also:

https://github.com/kubewarden/helm-charts/assets/2196685/d09bcc1a-66d7-4e47-a941-d1bbcd5fa98a

https://github.com/kubewarden/helm-charts/assets/2196685/fa97c41e-51dd-478a-bb02-aeb458a9e1ac

Additional Information

Changed name of sections, @kravciak this may mean changes to Kubewarden UI testsuite.

Tradeoff

Potential improvement

@aalves08 There are 2 UI bugs, unrelated to the questions.yaml changes:

viccuad commented 4 months ago

That is true, and I don't see any way to solve it. The chart json schema prevents installation though but it is ugly.

I'm already using a trick by setting an unexsistent value questions.ui.pdb in the radio, to be able to only show one of minAvailable or maxUnavailable. There's no other way to not show 1 of two fields (tried with enum, adding a non-existent policyServer.pdb.enable bool). It's a bit underwhelming to be honest. This bug also appears on the controller chart when ticking the jaeger config on or off.

viccuad commented 4 months ago

Copied previous work into viccuad/prod-questions-archive. Will open issues against rancher/dashboard and link this PR.

Rebased and dropped the buggy elements. Current state from this PR:

Screencast_2024-04-16_15:47:12.webm

Screencast_2024-04-16_15:48:18.webm

Ready for review.