search

kubewarden / helm-charts

Helm charts for the Kubewarden project
Apache License 2.0
25 stars 16 forks source link

feat: Add annotation `artifacthub/pkg` to policies #426

Closed viccuad closed 4 months ago

viccuad commented 4 months ago

Description

This allows the Rancher UI to find the policy package in artifacthub.io, and fetch its questions-ui from there. Hence allowing to show the policy settings when editing it.

Fixes https://github.com/rancher/kubewarden-ui/issues/669 Implementation (1) of https://github.com/rancher/kubewarden-ui/issues/669#issuecomment-2059507579

Test

Tested locally.

Additional Information

Tradeoff

Potential improvement

aalves08 commented 4 months ago

Another possible (and very controversial) solution is to get rid of these questions UI elements. Just use a YAML editor.

We don't have problems with UI elements that "appear" and "disappear". There's no version mismatch in terms of settings because the UI, right now, is getting the "questions" part from ArtifactHub to provide the settings UI for CAP's that come from a template (and which are not from the default policies) and we might get UI elements for settings that don't exist.

Food for thought 🙏 🤔 🙇

viccuad commented 4 months ago

Closing in favour of https://github.com/kubewarden/helm-charts/pull/427.