kubewarden / helm-charts

Helm charts for the Kubewarden project
Apache License 2.0
26 stars 15 forks source link

Automation: bump patch version by default #452

Closed fabriziosestito closed 3 weeks ago

fabriziosestito commented 1 month ago

Is your feature request related to a problem?

The Helm chart release automation bumps the charts by a minor version. Since in the most common scenario, we bump the container images version, we could instead default to a patch bump. If the Helm chart was changed (values added/removed, configuration changes, etc..) we will need to bump the versions manually.

Solution you'd like

No response

Alternatives you've considered

No response

Anything else?

No response

viccuad commented 3 weeks ago

The chart version informs about the features and compatibility of the chart WRT to helm upgrade. With that in mind, I believe:

This way, as a Kubernetes operator, one can know of the disruptiveness of the update by looking at the bump of version, and the extent of the features by looking at the bump of appVersion. This should be consistent with the RFC.

We could add an updatecli rule that diffs the previous version values.yaml against the proposed, and if they aren't mergeable, propose a major bump of the version. Or better, provide full schema of the values.yaml, and reason with that.

flavio commented 3 weeks ago

Closing, we've just agreed it's fine to bump the minor version