search

kubewarden / helm-charts

Helm charts for the Kubewarden project
Apache License 2.0
26 stars 15 forks source link

Revert the default policy server finalizer in use #468

Closed jvanz closed 1 month ago

jvanz commented 1 month ago

Description

This reverts commit e514fa7c65c45f3d631544e15c6a55208169a765. This is necessary because the controller using the same finalizer is not released yet.

jvanz commented 1 month ago

I think we do not need to update the test as @kravciak did here. Because this is a potential issue for our users using our Helm charts now.

viccuad commented 1 month ago

Note , this is a duplicate of https://github.com/kubewarden/helm-charts/pull/467 xD. I'm ok with this one, closing the other.

jvanz commented 1 month ago

Note , this is a duplicate of #467 xD. I'm ok with this one, closing the other.

Sorry, I've missed your PR. Closing this one.

jvanz commented 1 month ago

@viccuad I've tried to update your PR (using force push) to change a commit message and did a mess in the branch. Losing the commit with the fix. I'm sorry. I've fixed your comment in this PR and I'll merge it.

viccuad commented 4 weeks ago

@jvanz no problem! I'm glad that is out!