search

kubewarden / helm-charts

Helm charts for the Kubewarden project
Apache License 2.0
25 stars 16 forks source link

feat: questions for tolerations and affinity. #482

Closed jvanz closed 1 month ago

jvanz commented 2 months ago

Description

Updates the questions.yaml file adding two more questions to allow users define the tolerations and affinity used in the Helm charts via Rancher UI.

flavio commented 1 month ago

@jvanz let's give it a try to make sure everything works fine

jvanz commented 1 month ago

@jvanz let's give it a try to make sure everything works fine

Yeah, unfortunately we are still facing the issues reported by @viccuad on Rancher 2.8.5.

jvanz commented 1 month ago

@kubewarden/kubewarden-developers , I'm trying to add questions entries to map the new configuration. But the Rancher dashboard has issues that is making this extremely hard, if not impossible. It lacks some features to make it properly. This is also highlighted by @viccuad in this comment.

With the in mind, I think we should keep that out of the questions.yml until Rancher dashboard fixes the blocking issues

viccuad commented 1 month ago

I would suggest adding the questions but commented for now, with a link to the issues.

jvanz commented 1 month ago

I would suggest adding the questions but commented for now, with a link to the issues.

I personally do not like having code not use in the file. It makes it harder to read and maintain. I would prefer update the issue and wait for the fixes.

viccuad commented 1 month ago

I'm ok with that, let's open an issue, and link and close this PR then.

jvanz commented 1 month ago

I'm ok with that, let's open an issue, and link and close this PR then.

https://github.com/kubewarden/helm-charts/issues/483