search

kubewarden / kubewarden-controller

Manage admission policies in your Kubernetes cluster with ease
https://kubewarden.io
Apache License 2.0
182 stars 30 forks source link

feat: Add `PolicyServer.Spec.Affinity` field, refresh crds #695

Closed viccuad closed 3 months ago

viccuad commented 3 months ago

Description

Part of https://github.com/kubewarden/kubewarden-controller/issues/691

Test

CI, new unit tests.

Additional Information

Tradeoff

Potential improvement

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 50.30%. Comparing base (2d164ea) to head (d3c500c).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #695 +/- ## ========================================== - Coverage 50.58% 50.30% -0.29% ========================================== Files 26 26 Lines 1967 1970 +3 ========================================== - Hits 995 991 -4 - Misses 869 876 +7 Partials 103 103 ``` | [Flag](https://app.codecov.io/gh/kubewarden/kubewarden-controller/pull/695/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewarden) | Coverage Δ | | |---|---|---| | [integration-tests](https://app.codecov.io/gh/kubewarden/kubewarden-controller/pull/695/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewarden) | `69.24% <ø> (-1.47%)` | :arrow_down: | | [unit-tests](https://app.codecov.io/gh/kubewarden/kubewarden-controller/pull/695/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewarden) | `44.23% <100.00%> (+0.11%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewarden#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

flavio commented 3 months ago

it looks like the integration tests failed because of the old flaky test :sob:

viccuad commented 3 months ago

rebased onto main as needed, fixed unused usage of the new function.