search

kubewarden / kubewarden-controller

Manage admission policies in your Kubernetes cluster with ease
https://kubewarden.io
Apache License 2.0
182 stars 30 forks source link

fix: remove hardcoded zap development option #721

Closed fabriziosestito closed 2 months ago

fabriziosestito commented 2 months ago

Description

Removes Development: true flag from zap initialization.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 46.18%. Comparing base (d0ea5df) to head (a743bd7).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #721 +/- ## ========================================== - Coverage 51.95% 46.18% -5.77% ========================================== Files 27 22 -5 Lines 2050 1572 -478 ========================================== - Hits 1065 726 -339 + Misses 877 784 -93 + Partials 108 62 -46 ``` | [Flag](https://app.codecov.io/gh/kubewarden/kubewarden-controller/pull/721/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewarden) | Coverage Δ | | |---|---|---| | [integration-tests](https://app.codecov.io/gh/kubewarden/kubewarden-controller/pull/721/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewarden) | `?` | | | [unit-tests](https://app.codecov.io/gh/kubewarden/kubewarden-controller/pull/721/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewarden) | `46.18% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewarden#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jvanz commented 2 months ago

LGTM. As far as I can see, the CI is failing due the flaky test issue.