Closed flavio closed 1 month ago
Attention: Patch coverage is 50.00000%
with 10 lines
in your changes are missing coverage. Please review.
Project coverage is 71.78%. Comparing base (
9c3dd61
) to head (783f2bd
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@jvanz, @viccuad : I've updated golanglint-ci and then fixed all the warnings via 8d936333779b11f9cb2f1314341325b0f3af80a3. Please take a look at the commit description to see the reasons of the changes I've made
Note: this cannot be merged until the 1.12 release is done
It seems there is something wrong, because tests and linter are failing. =(
@jvanz I'm a bit stuck with other tasks, would you be so kind to take this over once your PR about the owner reference is merged? :pray:
@kubewarden/kubewarden-developers , I've updated this PR rebasing it on top of main and did some fixes to make the CI happy. To make all our CI green I had to update the controller-gen binary used. Otherwise, we get a nil pointer deref. That's why you can see so many line changes, I've commited the result of the generator after updating it. Let me know if you're fine with that. Otherwise, I can update the generator in another PR or commit the updated manifest files in another PR.
@kubewarden/kubewarden-developers I've updated this branch rebasing it on top of main and squashing some commits to reduce the number of them.
Use a more concise way to handle "not found" errors that is made possible by using a controller runtime helper.