kubewarden / kubewarden-controller

Manage admission policies in your Kubernetes cluster with ease
https://kubewarden.io
Apache License 2.0
189 stars 33 forks source link

dev: fix the tilt development file #751

Closed flavio closed 4 months ago

flavio commented 4 months ago

The name of the variable used by the helm chart to replace the system registry was wrong.

That caused tilt to NOT use its own patched image, making everything useless.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 50.19%. Comparing base (94ec1c4) to head (3c25b3b).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #751 +/- ## =========================================== - Coverage 72.36% 50.19% -22.18% =========================================== Files 28 23 -5 Lines 1806 1269 -537 =========================================== - Hits 1307 637 -670 - Misses 379 579 +200 + Partials 120 53 -67 ``` | [Flag](https://app.codecov.io/gh/kubewarden/kubewarden-controller/pull/751/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewarden) | Coverage Δ | | |---|---|---| | [integration-tests](https://app.codecov.io/gh/kubewarden/kubewarden-controller/pull/751/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewarden) | `?` | | | [unit-tests](https://app.codecov.io/gh/kubewarden/kubewarden-controller/pull/751/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewarden) | `50.19% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewarden#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.