search

kubewarden / kubewarden-controller

Manage admission policies in your Kubernetes cluster with ease
https://kubewarden.io
Apache License 2.0
189 stars 33 forks source link

fix: use domain qualified finalizers. #759

Closed jvanz closed 3 months ago

jvanz commented 3 months ago

Description

Updates the controller to use domain qualified finalizer and follow the best practices. By doing that we fix some warning from the KubeAPI.

Fix #728

Test

make tests
# Manual testing upgrading old Kubewarden to a version running the code
codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 46.15385% with 7 lines in your changes missing coverage. Please review.

Project coverage is 61.56%. Comparing base (adbdda6) to head (ce5792c).

Files Patch % Lines
internal/pkg/admission/testing_common.go 0.00% 3 Missing :warning:
controllers/policy_utils.go 60.00% 1 Missing and 1 partial :warning:
controllers/policyserver_controller.go 60.00% 1 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #759 +/- ## =========================================== - Coverage 73.20% 61.56% -11.64% =========================================== Files 28 28 Lines 1806 1816 +10 =========================================== - Hits 1322 1118 -204 - Misses 367 581 +214 Partials 117 117 ``` | [Flag](https://app.codecov.io/gh/kubewarden/kubewarden-controller/pull/759/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewarden) | Coverage Δ | | |---|---|---| | [integration-tests](https://app.codecov.io/gh/kubewarden/kubewarden-controller/pull/759/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewarden) | `61.56% <46.15%> (+0.54%)` | :arrow_up: | | [unit-tests](https://app.codecov.io/gh/kubewarden/kubewarden-controller/pull/759/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewarden) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewarden#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.