codecov[bot]
commented
1 week ago Codecov Report
Attention: Patch coverage is 81.57895% with 14 lines in your changes missing coverage. Please review.
Project coverage is 72.97%. Comparing base (
e3750b2) to head (c5a217e).
| Files | Patch % | Lines |
|---|---|---|
| internal/pkg/admission/policy-server-ca-secret.go | 73.33% | 6 Missing and 2 partials :warning: |
| internal/pkg/certs/certs.go | 86.36% | 3 Missing and 3 partials :warning: |
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #777 +/- ## ========================================== - Coverage 74.05% 72.97% -1.09% ========================================== Files 28 26 -2 Lines 1808 1780 -28 ========================================== - Hits 1339 1299 -40 - Misses 353 366 +13 + Partials 116 115 -1 ``` | [Flag](https://app.codecov.io/gh/kubewarden/kubewarden-controller/pull/777/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewarden) | Coverage Δ | | |---|---|---| | [integration-tests](https://app.codecov.io/gh/kubewarden/kubewarden-controller/pull/777/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewarden) | `60.61% <81.57%> (-1.28%)` | :arrow_down: | | [unit-tests](https://app.codecov.io/gh/kubewarden/kubewarden-controller/pull/777/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewarden) | `37.87% <0.00%> (-12.33%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewarden#carryforward-flags-in-the-pull-request-comment) to find out more.:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
fabriziosestito
Description
This PR refactors the generation utilities in the
admissionregistrationpackage, removing duplication and simplifying the current implementation. It renamesadmissionregistrationincertsand reactors the existing reconciler unit test in integration tests clauses.Additional info
This PR also changes the golangci configuration to add an exception for the
okmap index in thevarnamelenlinter. However we should uniform and clean up the golangci configurations across all the KW repos, this is tracked by: #778There are a few incongruences with the naming, for instance, this status https://github.com/kubewarden/kubewarden-controller/blob/030edce6f7c57d54b88453054e39f9baa20377cc/pkg/apis/policies/v1/policyserver_types.go#L132 should be probably named
CertSecretReconciledinstead. Fixing this is out of scope for this PR and I will create an issue about it.Fixes: #775, #664