search

kubewarden / kubewarden-end-to-end-tests

Files used to run Kubewarden end-to-end tests
https://kubewarden.io
Apache License 2.0
2 stars 6 forks source link

Reuse helm values in reconfiguration test #107

Closed kravciak closed 3 months ago

kravciak commented 3 months ago

Reconfiguration test on nightly job downgrades controller from latest to 1.13.0. This should fix the issue.

From debug with @jvanz : We have two finalizers: kubewarden (old one) and kubewarden.io/finalizer (the latest). In the test we are creating the cluster with the version v1.13.0 which uses the kubewarden finalizer. Then, we change the controller version to latest which will add the kubewarden.io/finalizer finalizer. However, during the reconfiguration tests we downgrade back to the v1.13.0 , right? Therefore, we ended in a situation where the controller does not "know" the new finalizer, because is the "old" version. Thus, the finalizer (kubewarden.io/finalizer ) is not removed and the resource is not deleted.

kravciak commented 3 months ago

LGTM. I don't see why to change the psp-user-group policy from ClusterAdmissionPolicy to AdmissionPolicy, though.

In YAML it's defined as AdmissionPolicy, but test is waiting for ClusterAdmissionPolicies. It's not changing policy type, just calling different wait function.