Closed jvanz closed 4 months ago
This is not ready to be merged. The testing is not passing locally.
E2E are passing since release of -rc1
: https://github.com/kubewarden/kubewarden-controller/actions/runs/9614262756
E2E are passing since release of
-rc1
: https://github.com/kubewarden/kubewarden-controller/actions/runs/9614262756
Yes, but I still think we should merge this. This will prevent future problems of downgrading the controller by accident. What do you think @kravciak ?
LGTM :)
Problem from my POV is that we need more robust solution (WIP).
I was fighting with --reuse-values
before, it fixes/breaks things based on situation.
See https://github.com/kubewarden/kubewarden-end-to-end-tests/pull/78/files for example...
If you faced issue with this flag before and the tests are passing now with the latest helm chart version, I'll close this. We can revisit this if something happen again.
Description
Reuse helm values in OpenTelemetry tests to avoid issues in the other tests due a recent change in the controller where the finalizer used has changed. Currently, the test downgrade the controller version causing an issue in tests ran after the OPTEL one. Using the
--reuse-values
fix the issue because the controller container image will not be changed.