Closed flavio closed 1 month ago
Attention: Patch coverage is 47.69231%
with 102 lines
in your changes missing coverage. Please review.
Project coverage is 13.43%. Comparing base (
ce7a88f
) to head (ddd8916
).
Files | Patch % | Lines |
---|---|---|
src/scaffold/admission_request.rs | 57.76% | 68 Missing :warning: |
src/cli.rs | 0.00% | 21 Missing :warning: |
src/main.rs | 0.00% | 11 Missing :warning: |
src/info.rs | 0.00% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
LGTM. But I have a question in mind, what happens if the user has multiple contexts in the kubeconfig? Will the catalog contains the kinds from the default context? I'm wondering about the UX for the user which is building a request for a CRDs which is not in the "default" context.
The catalog will be built from the default context.
If this is an issue at all, I don't think this is a huge issue as well and we do not need to fix it now. But if it is, is there an easy workaround for it? Like defining the context to be used or fetch resources from all the contexts ( I'm not sure if this is a good idea in end end as well ) .
Going through all the contexts would take time and also possible timeouts because maybe some of the clusters are not reachable.
It's good that you pointed out this possible limitation, but I would not focus on that right now. The scaffold code always generate something that will work for 99.9% of the policies.
We can find a solution to this corner case situation if someone complains about that.
This command creates a Kubernetes AdmissionRequest object starting from a Kubernetes Resource definition.
The following command:
produces an AdmissionRequest CREATE event for the given Ingress object.
Currently, only the CREATE operation is supported. The other operations will be added in the future.