Closed flavio closed 1 year ago
I just realized, should we use contextAwareResources
everywhere, also inside of the ClusterAdmissionPolicy
CRD and inside of Policy Server configuration file?
I think it would make everything consistent. What do you think about that?
I'm ok with using contextAwareResources
everywhere including CRDs, and deprecating contextAware
. It's a pity that we need to bump the CRDs, but it's needed.
I suppose we should have a new CRD version, deprecate the old version, and provide a conversion to the new one (that just sets contextAwareResources empty?)
I just realized, should we use
contextAwareResources
everywhere, also inside of theClusterAdmissionPolicy
CRD and inside of Policy Server configuration file?I think it would make everything consistent. What do you think about that?
Fine by me.
I'm ok with using
contextAwareResources
everywhere including CRDs, and deprecatingcontextAware
. It's a pity that we need to bump the CRDs, but it's needed. I suppose we should have a new CRD version, deprecate the old version, and provide a conversion to the new one (that just sets contextAwareResources empty?)
We never had contextAware
inside of the CRDs, we only had that inside of the policy metadata
I've updated the PR to use contextAwareResources
everywhere. Please double check :)
Current policies have already a metadata attribute named
contextAware
which has a boolean value.The initial proposal wanted to reuse this attribute to store a list of kubernetes resources.
Unfortunately this would be too complicated to do. We would have to write some custom deserialization code. Because of that, the RFC has been updated to use a different name for this metadata attribute.