search

kubewarden / rfc

Kubewarden's RFCs
https://github.com/kubewarden/
4 stars 5 forks source link

feat: Add state property to RFCs, give state to existing #3

Closed viccuad closed 2 years ago

viccuad commented 2 years ago

Description

Add state property to RFCs, give state to existing RFCs.

Shamelessly lifted from https://dep-team.pages.debian.net/deps/dep0/.

viccuad commented 2 years ago

Maybe this is too convoluted for our use case. If so, happy dropping it. Upsides for me is that it brings clarity and a foundation for community. Also, with draft and candidate states, means that one doesn't need to finish an RFC in the first PR, but we can iterate.

ereslibre commented 2 years ago

I think https://dep-team.pages.debian.net/deps/dep0/ is too complex to adapt as a complete workflow. I would keep Accepted and Rejected state only.

By default, when a RFC is created and a PR is opened, it is created with Accepted as the status. After discussion and adapting, if it merges, it is merged as Accepted.

If it is finally rejected or consensus is not reached, it is changed to Rejected and merged.

I would not go much further than that to be honest. Having a record of the RFC's that have been rejected in the tree is good enough for us I think.

viccuad commented 2 years ago

Yes, indeed, I went overboard. Simplified verbatim with your approach Rafa!