kubewharf / godel-scheduler

a unified scheduler for online and offline tasks
Apache License 2.0
377 stars 58 forks source link

[Bug] Missing CRD `customnoderesource` #16

Closed Yicheng-Lu-llll closed 5 months ago

Yicheng-Lu-llll commented 5 months ago

When I attempted to follow the instructions in dev-quickstart.md, I noticed that in the "Generate the required CRDs" step, only three CRDs were generated as shown below:

ubuntu@ip-172-31-2-249:~$ kubectl get crds
NAME                                       CREATED AT
nmnodes.node.godel.kubewharf.io            2024-01-19T04:34:21Z
podgroups.scheduling.godel.kubewharf.io    2024-01-19T04:34:21Z
schedulers.scheduling.godel.kubewharf.io   2024-01-19T04:34:21Z

However, the instructions imply there is another CRD: "customnoderesource." The absence of this CRD will prevent the dispatcher, scheduler and binder from starting, as evidenced by the error message below:

E0119 04:54:44.126106   79900 reflector.go:138] github.com/kubewharf/katalyst-api/pkg/client/informers/externalversions/factory.go:120: Failed to watch *v1alpha1.CustomNodeResource: failed to list *v1alpha1.CustomNodeResource: the server could not find the requested resource (get customnoderesources.node.katalyst.kubewharf.io)

After inspecting, it appears that there do have only three CRDs defined here: https://github.com/kubewharf/godel-scheduler-api/tree/main/pkg/apis. Perhaps customnoderesource should also be uploaded to the godel-scheduler-api repository? I believe it is used to store topology infomation.

NickrenREN commented 5 months ago

Hi, @Yicheng-Lu-llll , thanks for sending your issues.

NickrenREN commented 5 months ago

@yuey002 can you help update our quickstart doc when you have time ?

Yicheng-Lu-llll commented 5 months ago

I see, Thank you!

NickrenREN commented 5 months ago

@Yicheng-Lu-llll fyi: installation guide is added to README file in this MR: https://github.com/kubewharf/godel-scheduler/pull/17