kubewharf / godel-scheduler

a unified scheduler for online and offline tasks
Apache License 2.0
377 stars 58 forks source link

fix scheduler scheduling & preempting attempt metrics #27

Closed lzlaa closed 2 months ago

lzlaa commented 4 months ago

In the current implementation, when the Scheduling and Preempting stages fail, both scheduler_pod_scheduling_attempts{unschedulable} and scheduler_pod_preempting_attempts{nominatedFailure} will be recorded, leading to unclear semantics for these metrics.

In this MR:

zryfish commented 3 months ago

@lzlaa Please rebase and push again

NickrenREN commented 2 months ago

any new comments on this PR ? @zryfish @binacs

binacs commented 2 months ago

lgtm