search

kubewharf / godel-scheduler

a unified scheduler for online and offline tasks
Apache License 2.0
377 stars 58 forks source link

inProgress not set to false #32

Closed KunWuLuan closed 3 months ago

KunWuLuan commented 3 months ago

https://github.com/kubewharf/godel-scheduler/blob/80119ac0c3f9ddcc897c3659261d0bf3ea3688e0/pkg/binder/godel_binder.go#L457-L472

KunWuLuan commented 3 months ago

It seems inProgress is always true even if time.Now().After(ddl) return true. Is this as expected?

NickrenREN commented 3 months ago

@XinyiSong PTAL

lzlaa commented 3 months ago

It seems inProgress is always true even if time.Now().After(ddl) return true. Is this as expected?

Thanks for your comment @KunWuLuan

There should have a return, I have pushed a fix in #35 .

Luckily it won't cause incorrect result for timeout task. When the task timeout checkCrossNodePreemptionForAssumedTask returns an error, so the task will be moved to failedList correctly.