search

kubewharf / godel-scheduler

a unified scheduler for online and offline tasks
Apache License 2.0
377 stars 58 forks source link

update podgroup crd #33

Closed lzlaa closed 2 months ago

lzlaa commented 3 months ago

update podgroup crd.

more details refer to kubewharf/godel-scheduler-api/pull/3

lintongj commented 3 months ago

Based on my understanding, to add additional print columns, you are supposed to add some code generate annotation somewhere around https://github.com/kubewharf/godel-scheduler-api/blob/main/pkg/apis/scheduling/v1alpha1/types.go#L96. But I checked your PR at https://github.com/kubewharf/godel-scheduler-api/pull/3, I didn't see anything like that but a change in CRD yaml. Is it expected?

lzlaa commented 3 months ago

Based on my understanding, to add additional print columns, you are supposed to add some code generate annotation somewhere around https://github.com/kubewharf/godel-scheduler-api/blob/main/pkg/apis/scheduling/v1alpha1/types.go#L96. But I checked your PR at kubewharf/godel-scheduler-api#3, I didn't see anything like that but a change in CRD yaml. Is it expected?

Thanks for your reminder. I have added the kubebuilder marker in file and copy the geneated crd, please double check whether it is reasonable. @lintongj