search

kubewharf / katalyst-core

Katalyst aims to provide a universal solution to help improve resource utilization and optimize the overall costs in the cloud. This is the core components in Katalyst system, including multiple agents and centralized components
Apache License 2.0
394 stars 91 forks source link

fix(sysadvisor): numa balancer miss eviction #506

Closed zzzzhhb closed 4 months ago

zzzzhhb commented 4 months ago

What type of PR is this?

Bug fixes

What this PR does / why we need it:

  1. fixs the bug that the pod will never be evicted when GetAdvice is called prior to GetEvictPods.
  2. don't skip the evicted pod when finding the balanced pod since eviction might not succeed.

Which issue(s) this PR fixes:

Special notes for your reviewer:

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 55.13%. Comparing base (65db018) to head (af2ab76).

Files Patch % Lines
...qosaware/resource/memory/plugin/memory_balancer.go 75.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #506 +/- ## ========================================== + Coverage 55.03% 55.13% +0.10% ========================================== Files 513 513 Lines 56959 56958 -1 ========================================== + Hits 31346 31404 +58 + Misses 22267 22198 -69 - Partials 3346 3356 +10 ``` | [Flag](https://app.codecov.io/gh/kubewharf/katalyst-core/pull/506/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf) | Coverage Δ | | |---|---|---| | [unittest](https://app.codecov.io/gh/kubewharf/katalyst-core/pull/506/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf) | `55.13% <75.00%> (+0.10%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.