search

kubewharf / katalyst-core

Katalyst aims to provide a universal solution to help improve resource utilization and optimize the overall costs in the cloud. This is the core components in Katalyst system, including multiple agents and centralized components
Apache License 2.0
394 stars 91 forks source link

Malachite adapt to network metrics #510

Closed waynepeking348 closed 3 months ago

waynepeking348 commented 3 months ago

What type of PR is this?

Enhancements

What this PR does / why we need it:

  1. fix bugs for kcmas collecting hang (if corresponding servers are all shut down)
  2. add network-related metrics in malachite provisioner
codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 59.21053% with 62 lines in your changes are missing coverage. Please review.

Project coverage is 55.64%. Comparing base (91a4393) to head (41bf909). Report is 6 commits behind head on main.

Files Patch % Lines
.../agent/metric/provisioner/malachite/provisioner.go 62.59% 44 Missing and 5 partials :warning:
pkg/util/metric/store.go 44.44% 10 Missing :warning:
pkg/custom-metric/store/remote/remote_store.go 0.00% 2 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #510 +/- ## ========================================== + Coverage 55.33% 55.64% +0.31% ========================================== Files 552 552 Lines 59127 59316 +189 ========================================== + Hits 32715 33005 +290 + Misses 23003 22873 -130 - Partials 3409 3438 +29 ``` | [Flag](https://app.codecov.io/gh/kubewharf/katalyst-core/pull/510/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf) | Coverage Δ | | |---|---|---| | [unittest](https://app.codecov.io/gh/kubewharf/katalyst-core/pull/510/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf) | `55.64% <59.21%> (+0.31%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.