search

kubewharf / katalyst-core

Katalyst aims to provide a universal solution to help improve resource utilization and optimize the overall costs in the cloud. This is the core components in Katalyst system, including multiple agents and centralized components
Apache License 2.0
419 stars 103 forks source link

feat(sysadvisor): optimize advisor qosaware update logic #514

Closed nightmeng closed 6 months ago

nightmeng commented 6 months ago

What type of PR is this?

Enhancements

What this PR does / why we need it:

Optimize advisor qosaware update logic.

Which issue(s) this PR fixes:

Special notes for your reviewer:

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 60.00000% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 55.49%. Comparing base (91a4393) to head (050340f). Report is 3 commits behind head on main.

Files Patch % Lines
...sysadvisor/plugin/qosaware/resource/cpu/advisor.go 50.00% 10 Missing and 1 partial :warning:
...advisor/plugin/qosaware/resource/memory/advisor.go 76.92% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #514 +/- ## ========================================== + Coverage 55.33% 55.49% +0.16% ========================================== Files 552 552 Lines 59127 59190 +63 ========================================== + Hits 32715 32847 +132 + Misses 23003 22917 -86 - Partials 3409 3426 +17 ``` | [Flag](https://app.codecov.io/gh/kubewharf/katalyst-core/pull/514/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf) | Coverage Δ | | |---|---|---| | [unittest](https://app.codecov.io/gh/kubewharf/katalyst-core/pull/514/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf) | `55.49% <60.00%> (+0.16%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.