search

kubewharf / katalyst-core

Katalyst aims to provide a universal solution to help improve resource utilization and optimize the overall costs in the cloud. This is the core components in Katalyst system, including multiple agents and centralized components
Apache License 2.0
394 stars 91 forks source link

feat(eviction): add eviction pod metric labels #523

Closed nightmeng closed 3 months ago

nightmeng commented 3 months ago

What type of PR is this?

Enhancements

What this PR does / why we need it:

Support add specified pod labels into metric selectors.

Which issue(s) this PR fixes:

Special notes for your reviewer:

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 40.00000% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 55.34%. Comparing base (58177dd) to head (845ad82).

Files Patch % Lines
pkg/agent/evictionmanager/manager.go 37.50% 14 Missing and 1 partial :warning:
...talyst-agent/app/options/eviction/eviction_base.go 25.00% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #523 +/- ## ========================================== - Coverage 55.55% 55.34% -0.21% ========================================== Files 552 552 Lines 59381 59398 +17 ========================================== - Hits 32988 32875 -113 - Misses 22961 23088 +127 - Partials 3432 3435 +3 ``` | [Flag](https://app.codecov.io/gh/kubewharf/katalyst-core/pull/523/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf) | Coverage Δ | | |---|---|---| | [unittest](https://app.codecov.io/gh/kubewharf/katalyst-core/pull/523/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf) | `55.34% <40.00%> (-0.21%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.