search

kubewharf / katalyst-core

Katalyst aims to provide a universal solution to help improve resource utilization and optimize the overall costs in the cloud. This is the core components in Katalyst system, including multiple agents and centralized components
Apache License 2.0
394 stars 91 forks source link

feat(advisor): fix cpu advisor calc checking logic #526

Closed nightmeng closed 3 months ago

nightmeng commented 3 months ago

What type of PR is this?

Bug fixes

What this PR does / why we need it:

only check share and reclaimed cores pod.

Which issue(s) this PR fixes:

Special notes for your reviewer:

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 55.60%. Comparing base (569d59f) to head (39d41be). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #526 +/- ## ========================================== + Coverage 55.37% 55.60% +0.22% ========================================== Files 552 552 Lines 59398 59416 +18 ========================================== + Hits 32893 33036 +143 + Misses 23075 22935 -140 - Partials 3430 3445 +15 ``` | [Flag](https://app.codecov.io/gh/kubewharf/katalyst-core/pull/526/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf) | Coverage Δ | | |---|---|---| | [unittest](https://app.codecov.io/gh/kubewharf/katalyst-core/pull/526/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf) | `55.60% <100.00%> (+0.22%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.