search

kubewharf / katalyst-core

Katalyst aims to provide a universal solution to help improve resource utilization and optimize the overall costs in the cloud. This is the core components in Katalyst system, including multiple agents and centralized components
Apache License 2.0
394 stars 91 forks source link

feat(topology scheduler plugin): check shared resource in topologyMatch #527

Open WangZzzhe opened 3 months ago

WangZzzhe commented 3 months ago

What type of PR is this?

Enhancements

What this PR does / why we need it:

when scheduling dedicated pods and shared pods, it is necessary to check whether the shared resources of the node are sufficient for shared pods, because shared pods can not be allocated on the same NUMAs with dedicated pods. And it will not be verified in katalyst-agent.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 88.12500% with 19 lines in your changes are missing coverage. Please review.

Project coverage is 56.70%. Comparing base (74b648c) to head (ca3728f). Report is 5 commits behind head on main.

Files Patch % Lines
.../scheduler/plugins/noderesourcetopology/reserve.go 60.00% 4 Missing and 2 partials :warning:
pkg/scheduler/cache/nodeinfo.go 91.37% 3 Missing and 2 partials :warning:
pkg/scheduler/eventhandlers/pod_handler.go 0.00% 3 Missing :warning:
...g/scheduler/plugins/noderesourcetopology/filter.go 92.30% 2 Missing and 1 partial :warning:
...r/plugins/noderesourcetopology/filter_dedicated.go 86.66% 1 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #527 +/- ## ========================================== + Coverage 56.06% 56.70% +0.64% ========================================== Files 534 561 +27 Lines 49807 51677 +1870 ========================================== + Hits 27924 29305 +1381 - Misses 18325 18661 +336 - Partials 3558 3711 +153 ``` | [Flag](https://app.codecov.io/gh/kubewharf/katalyst-core/pull/527/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf) | Coverage Δ | | |---|---|---| | [unittest](https://app.codecov.io/gh/kubewharf/katalyst-core/pull/527/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf) | `56.70% <88.12%> (+0.64%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.