search

kubewharf / katalyst-core

Katalyst aims to provide a universal solution to help improve resource utilization and optimize the overall costs in the cloud. This is the core components in Katalyst system, including multiple agents and centralized components
Apache License 2.0
394 stars 91 forks source link

feat(kcmas): enable grouped aggregate metric #530

Closed zzzzhhb closed 3 months ago

zzzzhhb commented 3 months ago

What type of PR is this?

Features

What this PR does / why we need it:

enable grouped aggregate metric

Which issue(s) this PR fixes:

Special notes for your reviewer:

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 70.40000% with 37 lines in your changes are missing coverage. Please review.

Project coverage is 55.44%. Comparing base (b122f7b) to head (6931299).

Files Patch % Lines
pkg/custom-metric/store/data/internal/internal.go 65.26% 27 Missing and 6 partials :warning:
pkg/custom-metric/store/data/cache.go 88.88% 2 Missing and 1 partial :warning:
pkg/custom-metric/provider/util.go 0.00% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #530 +/- ## ========================================== - Coverage 55.67% 55.44% -0.24% ========================================== Files 552 552 Lines 59419 59449 +30 ========================================== - Hits 33083 32961 -122 - Misses 22899 23048 +149 - Partials 3437 3440 +3 ``` | [Flag](https://app.codecov.io/gh/kubewharf/katalyst-core/pull/530/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf) | Coverage Δ | | |---|---|---| | [unittest](https://app.codecov.io/gh/kubewharf/katalyst-core/pull/530/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf) | `55.44% <70.40%> (-0.24%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.