search

kubewharf / katalyst-core

Katalyst aims to provide a universal solution to help improve resource utilization and optimize the overall costs in the cloud. This is the core components in Katalyst system, including multiple agents and centralized components
Apache License 2.0
419 stars 103 forks source link

add model version for inference results #531

Closed justadogistaken closed 5 months ago

justadogistaken commented 6 months ago

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 47.86325% with 61 lines in your changes are missing coverage. Please review.

Project coverage is 55.41%. Comparing base (21c243d) to head (c472b00). Report is 2 commits behind head on main.

:exclamation: Current head c472b00 differs from pull request most recent head 43f4ef5. Consider uploading reports for the commit 43f4ef5 to get more accurate results

Files Patch % Lines
...ce/models/borwein/inferencesvc/inference_svc.pb.go 4.25% 43 Missing and 2 partials :warning:
pkg/custom-metric/store/data/internal/internal.go 81.81% 10 Missing and 2 partials :warning:
...sadvisor/plugin/metric-emitter/syncer/pod/model.go 0.00% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #531 +/- ## ========================================== - Coverage 55.47% 55.41% -0.07% ========================================== Files 552 552 Lines 59419 59498 +79 ========================================== + Hits 32965 32970 +5 - Misses 23022 23098 +76 + Partials 3432 3430 -2 ``` | [Flag](https://app.codecov.io/gh/kubewharf/katalyst-core/pull/531/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf) | Coverage Δ | | |---|---|---| | [unittest](https://app.codecov.io/gh/kubewharf/katalyst-core/pull/531/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf) | `55.41% <47.86%> (-0.07%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.