search

kubewharf / katalyst-core

Katalyst aims to provide a universal solution to help improve resource utilization and optimize the overall costs in the cloud. This is the core components in Katalyst system, including multiple agents and centralized components
Apache License 2.0
394 stars 91 forks source link

reduce the frequency of spd manager try to get unused spd from remote api-server #532

Closed luomingmeng closed 3 months ago

luomingmeng commented 3 months ago

What type of PR is this?

Bug fixes

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 82.60870% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 55.30%. Comparing base (569d59f) to head (97a88f4). Report is 6 commits behind head on main.

Files Patch % Lines
pkg/metaserver/spd/cache.go 76.92% 2 Missing and 1 partial :warning:
pkg/metaserver/spd/fetcher.go 90.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #532 +/- ## ========================================== - Coverage 55.37% 55.30% -0.08% ========================================== Files 552 552 Lines 59398 59435 +37 ========================================== - Hits 32893 32871 -22 - Misses 23075 23124 +49 - Partials 3430 3440 +10 ``` | [Flag](https://app.codecov.io/gh/kubewharf/katalyst-core/pull/532/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf) | Coverage Δ | | |---|---|---| | [unittest](https://app.codecov.io/gh/kubewharf/katalyst-core/pull/532/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf) | `55.30% <82.60%> (-0.08%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.