search

kubewharf / katalyst-core

Katalyst aims to provide a universal solution to help improve resource utilization and optimize the overall costs in the cloud. This is the core components in Katalyst system, including multiple agents and centralized components
Apache License 2.0
419 stars 103 forks source link

chore(sysadvisor): refine some healthcheck rule #543

Closed zzzzhhb closed 5 months ago

zzzzhhb commented 5 months ago

What type of PR is this?

Enhancements

What this PR does / why we need it:

refine some healthcheck rule

Which issue(s) this PR fixes:

Special notes for your reviewer:

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 83.33333% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 55.64%. Comparing base (b122f7b) to head (bc14845). Report is 14 commits behind head on main.

:exclamation: Current head bc14845 differs from pull request most recent head 594b612. Consider uploading reports for the commit 594b612 to get more accurate results

Files Patch % Lines
pkg/agent/resourcemanager/fetcher/manager.go 50.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #543 +/- ## ========================================== - Coverage 55.67% 55.64% -0.04% ========================================== Files 552 555 +3 Lines 59419 60130 +711 ========================================== + Hits 33083 33459 +376 - Misses 22899 23202 +303 - Partials 3437 3469 +32 ``` | [Flag](https://app.codecov.io/gh/kubewharf/katalyst-core/pull/543/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf) | Coverage Δ | | |---|---|---| | [unittest](https://app.codecov.io/gh/kubewharf/katalyst-core/pull/543/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf) | `55.64% <83.33%> (-0.04%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.