search

kubewharf / katalyst-core

Katalyst aims to provide a universal solution to help improve resource utilization and optimize the overall costs in the cloud. This is the core components in Katalyst system, including multiple agents and centralized components
Apache License 2.0
420 stars 103 forks source link

feat: Add TransparentMemoryOffloading plugin to trigger memory offloading #549

Closed cheney-lin closed 5 months ago

cheney-lin commented 5 months ago

What type of PR is this?

Enhancements

What this PR does / why we need it:

This feature provides ability to trigger memory offload to save memory without performance downgrade, saved memory could be used for deploy more reclaimed_cores workloads to raise CPU utilization.

Which issue(s) this PR fixes:

Special notes for your reviewer:

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 55.51537% with 246 lines in your changes are missing coverage. Please review.

Project coverage is 55.94%. Comparing base (88bd3ae) to head (7a1e3f1). Report is 23 commits behind head on main.

Files Patch % Lines
...saware/resource/memory/plugin/memory_offloading.go 66.33% 70 Missing and 33 partials :warning:
pkg/util/cgroup/manager/cgroup.go 32.50% 41 Missing and 13 partials :warning:
...ins/memory/dynamicpolicy/policy_advisor_handler.go 24.39% 30 Missing and 1 partial :warning:
...tions/dynamic/tmo/tmodefault/tmo_default_config.go 52.63% 18 Missing :warning:
.../agent/metric/provisioner/malachite/provisioner.go 56.00% 11 Missing :warning:
...sadvisor/plugin/qosaware/resource/helper/helper.go 36.36% 7 Missing :warning:
pkg/util/general/common.go 0.00% 5 Missing :warning:
pkg/util/metric/store.go 66.66% 5 Missing :warning:
pkg/util/cgroup/manager/v2/fs_linux.go 62.50% 1 Missing and 2 partials :warning:
...katalyst-agent/app/options/dynamic/tmo/tmo_base.go 77.77% 2 Missing :warning:
... and 4 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #549 +/- ## ========================================== + Coverage 55.78% 55.94% +0.15% ========================================== Files 524 532 +8 Lines 48534 49593 +1059 ========================================== + Hits 27077 27744 +667 - Misses 18025 18316 +291 - Partials 3432 3533 +101 ``` | [Flag](https://app.codecov.io/gh/kubewharf/katalyst-core/pull/549/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf) | Coverage Δ | | |---|---|---| | [unittest](https://app.codecov.io/gh/kubewharf/katalyst-core/pull/549/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf) | `55.94% <55.51%> (+0.15%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.