search

kubewharf / katalyst-core

Katalyst aims to provide a universal solution to help improve resource utilization and optimize the overall costs in the cloud. This is the core components in Katalyst system, including multiple agents and centralized components
Apache License 2.0
420 stars 103 forks source link

ioweight: adding pod level setting #550

Closed lubinszARM closed 2 months ago

lubinszARM commented 5 months ago

What type of PR is this?

Bug fixes

What this PR does / why we need it:

[bugfix] Missing pod level setting for io.weight

Which issue(s) this PR fixes:

Missing pod level setting for io.weight

Special notes for your reviewer:

None

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 55.81395% with 19 lines in your changes missing coverage. Please review.

Project coverage is 56.74%. Comparing base (d3a4e78) to head (135eee0). Report is 18 commits behind head on main.

Files Patch % Lines
...qrm-plugins/io/handlers/ioweight/ioweight_linux.go 43.75% 9 Missing :warning:
...ent/qrm-plugins/io/handlers/iocost/iocost_linux.go 65.21% 8 Missing :warning:
cmd/katalyst-agent/app/options/qrm/io_plugin.go 50.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #550 +/- ## ========================================== - Coverage 56.82% 56.74% -0.09% ========================================== Files 545 545 Lines 51559 52018 +459 ========================================== + Hits 29300 29518 +218 - Misses 18549 18779 +230 - Partials 3710 3721 +11 ``` | [Flag](https://app.codecov.io/gh/kubewharf/katalyst-core/pull/550/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf) | Coverage Δ | | |---|---|---| | [unittest](https://app.codecov.io/gh/kubewharf/katalyst-core/pull/550/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf) | `56.74% <55.81%> (-0.09%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.