search

kubewharf / katalyst-core

Katalyst aims to provide a universal solution to help improve resource utilization and optimize the overall costs in the cloud. This is the core components in Katalyst system, including multiple agents and centralized components
Apache License 2.0
388 stars 91 forks source link

support share cores with numa binding #554

Closed nightmeng closed 3 weeks ago

nightmeng commented 2 months ago

What type of PR is this?

Features

What this PR does / why we need it:

Support share cores with NUMA binding

Which issue(s) this PR fixes:

Special notes for your reviewer:

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 76.01810% with 53 lines in your changes missing coverage. Please review.

Project coverage is 56.45%. Comparing base (3a0e668) to head (53bec7b).

Files Patch % Lines
...sysadvisor/plugin/qosaware/resource/cpu/advisor.go 55.55% 18 Missing and 6 partials :warning:
pkg/agent/sysadvisor/metacache/metacache.go 27.77% 10 Missing and 3 partials :warning:
...u/assembler/provisionassembler/assembler_common.go 92.10% 3 Missing and 3 partials :warning:
...n/qosaware/resource/cpu/isolation/isolator_load.go 44.44% 2 Missing and 3 partials :warning:
...st-agent/app/options/sysadvisor/sysadvisor_base.go 70.00% 3 Missing :warning:
...in/inference/modelresultfetcher/borwein/borwein.go 0.00% 0 Missing and 1 partial :warning:
pkg/agent/sysadvisor/plugin/metacache/metacache.go 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #554 +/- ## ========================================== - Coverage 56.51% 56.45% -0.07% ========================================== Files 543 544 +1 Lines 50984 51117 +133 ========================================== + Hits 28815 28857 +42 - Misses 18500 18597 +97 + Partials 3669 3663 -6 ``` | [Flag](https://app.codecov.io/gh/kubewharf/katalyst-core/pull/554/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf) | Coverage Δ | | |---|---|---| | [unittest](https://app.codecov.io/gh/kubewharf/katalyst-core/pull/554/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf) | `56.45% <76.01%> (-0.07%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

waynepeking348 commented 2 months ago

what's the difference between this pr and https://github.com/kubewharf/katalyst-core/pull/481 ?