search

kubewharf / katalyst-core

Katalyst aims to provide a universal solution to help improve resource utilization and optimize the overall costs in the cloud. This is the core components in Katalyst system, including multiple agents and centralized components
Apache License 2.0
388 stars 91 forks source link

feat(qrm): support shared_cores with numa_binding #556

Closed csfldf closed 3 weeks ago

csfldf commented 2 months ago

feat(qrm): support shared_cores with numa_binding

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 62.43243% with 278 lines in your changes missing coverage. Please review.

Project coverage is 56.25%. Comparing base (2a9f961) to head (22693d7). Report is 1 commits behind head on main.

Files Patch % Lines
...ns/cpu/dynamicpolicy/policy_allocation_handlers.go 60.57% 81 Missing and 29 partials :warning:
...agent/qrm-plugins/cpu/dynamicpolicy/state/state.go 56.36% 28 Missing and 20 partials :warning:
...-plugins/cpu/dynamicpolicy/policy_hint_handlers.go 71.20% 27 Missing and 9 partials :warning:
.../agent/qrm-plugins/cpu/dynamicpolicy/state/util.go 77.39% 15 Missing and 11 partials :warning:
...lugins/cpu/dynamicpolicy/policy_advisor_handler.go 44.82% 13 Missing and 3 partials :warning:
...qrm-plugins/cpu/dynamicpolicy/cpuadvisor/helper.go 48.14% 12 Missing and 2 partials :warning:
...u/dynamicpolicy/validator/validator_cpu_advisor.go 30.00% 6 Missing and 1 partial :warning:
pkg/agent/qrm-plugins/cpu/dynamicpolicy/policy.go 33.33% 5 Missing and 1 partial :warning:
pkg/util/machine/util.go 0.00% 6 Missing :warning:
cmd/katalyst-agent/app/options/qrm/cpu_plugin.go 42.85% 4 Missing :warning:
... and 2 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #556 +/- ## ========================================== - Coverage 56.34% 56.25% -0.09% ========================================== Files 543 543 Lines 50373 50958 +585 ========================================== + Hits 28381 28667 +286 - Misses 18391 18621 +230 - Partials 3601 3670 +69 ``` | [Flag](https://app.codecov.io/gh/kubewharf/katalyst-core/pull/556/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf) | Coverage Δ | | |---|---|---| | [unittest](https://app.codecov.io/gh/kubewharf/katalyst-core/pull/556/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf) | `56.25% <62.43%> (-0.09%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.