search

kubewharf / katalyst-core

Katalyst aims to provide a universal solution to help improve resource utilization and optimize the overall costs in the cloud. This is the core components in Katalyst system, including multiple agents and centralized components
Apache License 2.0
420 stars 103 forks source link

feat: agent get SPD syncly #558

Open ddjjia opened 5 months ago

ddjjia commented 5 months ago

What type of PR is this?

Features

What this PR does / why we need it:

get spd from remote if not in cache when GetFromRemote is true

Which issue(s) this PR fixes:

Special notes for your reviewer:

CLAassistant commented 5 months ago

CLA assistant check
All committers have signed the CLA.

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 53.84615% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 55.90%. Comparing base (74b648c) to head (b49efba).

:exclamation: Current head b49efba differs from pull request most recent head d57b8bb. Consider uploading reports for the commit d57b8bb to get more accurate results

Files Patch % Lines
pkg/metaserver/spd/fetcher.go 52.17% 8 Missing and 3 partials :warning:
...atalyst-agent/app/options/metaserver/metaserver.go 66.66% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #558 +/- ## ========================================== - Coverage 56.06% 55.90% -0.17% ========================================== Files 534 534 Lines 49807 49828 +21 ========================================== - Hits 27924 27856 -68 - Misses 18325 18420 +95 + Partials 3558 3552 -6 ``` | [Flag](https://app.codecov.io/gh/kubewharf/katalyst-core/pull/558/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf) | Coverage Δ | | |---|---|---| | [unittest](https://app.codecov.io/gh/kubewharf/katalyst-core/pull/558/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf) | `55.90% <53.84%> (-0.17%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.