search

kubewharf / katalyst-core

Katalyst aims to provide a universal solution to help improve resource utilization and optimize the overall costs in the cloud. This is the core components in Katalyst system, including multiple agents and centralized components
Apache License 2.0
388 stars 91 forks source link

feat(controller): spd creation improvement #561

Open ddjjia opened 2 months ago

ddjjia commented 2 months ago

What type of PR is this?

Features

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

CLAassistant commented 2 months ago

CLA assistant check
All committers have signed the CLA.

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 55.47445% with 61 lines in your changes are missing coverage. Please review.

Project coverage is 55.96%. Comparing base (74b648c) to head (f8f6c9b). Report is 12 commits behind head on main.

Files Patch % Lines
pkg/controller/spd/spd.go 55.96% 36 Missing and 12 partials :warning:
pkg/util/spd.go 40.00% 4 Missing and 2 partials :warning:
pkg/controller/spd/indicator-plugin/manager.go 64.28% 3 Missing and 2 partials :warning:
pkg/controller/spd/indicator-plugin/plugin.go 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #561 +/- ## ========================================== - Coverage 56.06% 55.96% -0.11% ========================================== Files 534 535 +1 Lines 49807 49974 +167 ========================================== + Hits 27924 27966 +42 - Misses 18325 18441 +116 - Partials 3558 3567 +9 ``` | [Flag](https://app.codecov.io/gh/kubewharf/katalyst-core/pull/561/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf) | Coverage Δ | | |---|---|---| | [unittest](https://app.codecov.io/gh/kubewharf/katalyst-core/pull/561/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf) | `55.96% <55.47%> (-0.11%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.