search

kubewharf / katalyst-core

Katalyst aims to provide a universal solution to help improve resource utilization and optimize the overall costs in the cloud. This is the core components in Katalyst system, including multiple agents and centralized components
Apache License 2.0
388 stars 91 forks source link

feat(qrm&advisor): add flag allow_shared_cores_overlap_reclaimed_cores to ListAndWatchResponse from cpu advisor #569

Closed csfldf closed 2 months ago

csfldf commented 2 months ago

feat(qrm&advisor): add flag allow_shared_cores_overlap_reclaimed_cores to ListAndWatchResponse from cpu advisor

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 0.78740% with 126 lines in your changes are missing coverage. Please review.

Project coverage is 55.84%. Comparing base (7a1e3f1) to head (ce279d5). Report is 4 commits behind head on main.

Files Patch % Lines
...qrm-plugins/cpu/dynamicpolicy/cpuadvisor/cpu.pb.go 1.49% 64 Missing and 2 partials :warning:
pkg/agent/qrm-plugins/advisorsvc/advisor_svc.pb.go 0.00% 35 Missing :warning:
...ce/models/borwein/inferencesvc/inference_svc.pb.go 0.00% 25 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #569 +/- ## ========================================== - Coverage 55.94% 55.84% -0.10% ========================================== Files 532 532 Lines 49593 49724 +131 ========================================== + Hits 27744 27768 +24 - Misses 18316 18415 +99 - Partials 3533 3541 +8 ``` | [Flag](https://app.codecov.io/gh/kubewharf/katalyst-core/pull/569/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf) | Coverage Δ | | |---|---|---| | [unittest](https://app.codecov.io/gh/kubewharf/katalyst-core/pull/569/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf) | `55.84% <0.78%> (-0.10%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.