search

kubewharf / katalyst-core

Katalyst aims to provide a universal solution to help improve resource utilization and optimize the overall costs in the cloud. This is the core components in Katalyst system, including multiple agents and centralized components
Apache License 2.0
388 stars 91 forks source link

add healthz metrics #570

Closed zzzzhhb closed 2 months ago

zzzzhhb commented 2 months ago

What type of PR is this?

What this PR does / why we need it:

This PR adds metrics related to healthz.

Which issue(s) this PR fixes:

Special notes for your reviewer:

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 27.27273% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 55.97%. Comparing base (ed74702) to head (5e5ffd1).

:exclamation: Current head 5e5ffd1 differs from pull request most recent head 1045070. Consider uploading reports for the commit 1045070 to get more accurate results

Files Patch % Lines
cmd/base/healthz.go 22.22% 7 Missing :warning:
cmd/base/context.go 50.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #570 +/- ## ========================================== - Coverage 56.06% 55.97% -0.09% ========================================== Files 532 532 Lines 49724 49727 +3 ========================================== - Hits 27877 27836 -41 - Misses 18288 18352 +64 + Partials 3559 3539 -20 ``` | [Flag](https://app.codecov.io/gh/kubewharf/katalyst-core/pull/570/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf) | Coverage Δ | | |---|---|---| | [unittest](https://app.codecov.io/gh/kubewharf/katalyst-core/pull/570/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf) | `55.97% <27.27%> (-0.09%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.