search

kubewharf / katalyst-core

Katalyst aims to provide a universal solution to help improve resource utilization and optimize the overall costs in the cloud. This is the core components in Katalyst system, including multiple agents and centralized components
Apache License 2.0
420 stars 103 forks source link

feat: support dynamic config for reclaimed_cores overlaping shared_cores #576

Closed cheney-lin closed 4 months ago

cheney-lin commented 4 months ago

What type of PR is this?

Features

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 61.53846% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 55.80%. Comparing base (29a7b82) to head (0400806).

Files Patch % Lines
...app/options/dynamic/adminqos/advisor/cpu_region.go 60.00% 4 Missing :warning:
...p/options/dynamic/adminqos/advisor/advisor_base.go 66.66% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #576 +/- ## ========================================== + Coverage 55.77% 55.80% +0.02% ========================================== Files 532 533 +1 Lines 49717 49730 +13 ========================================== + Hits 27732 27753 +21 + Misses 18450 18435 -15 - Partials 3535 3542 +7 ``` | [Flag](https://app.codecov.io/gh/kubewharf/katalyst-core/pull/576/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf) | Coverage Δ | | |---|---|---| | [unittest](https://app.codecov.io/gh/kubewharf/katalyst-core/pull/576/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf) | `55.80% <61.53%> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.