search

kubewharf / katalyst-core

Katalyst aims to provide a universal solution to help improve resource utilization and optimize the overall costs in the cloud. This is the core components in Katalyst system, including multiple agents and centralized components
Apache License 2.0
388 stars 91 forks source link

WIP：MBM controller part 1 - skeletal code and options #579

Closed h-w-chen closed 3 weeks ago

h-w-chen commented 1 month ago

this PR will be held off (NOT to be merged into main branch) until it has majority functionalities in place and undergone verification

What type of PR is this?

Features

What this PR does / why we need it:

this PR is skeletal code of MBM controller, focusing on being part of cpu plugin and its options.

Which issue(s) this PR fixes:

NA

Special notes for your reviewer:

CLAassistant commented 1 month ago

CLA assistant check
All committers have signed the CLA.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 71.73913% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 55.98%. Comparing base (17dfadc) to head (a4ff1d1). Report is 7 commits behind head on main.

Files Patch % Lines
pkg/agent/qrm-plugins/cpu/dynamicpolicy/policy.go 0.00% 9 Missing and 1 partial :warning:
cmd/katalyst-agent/app/options/qrm/cpu_plugin.go 85.71% 1 Missing and 2 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #579 +/- ## ========================================== + Coverage 55.80% 55.98% +0.17% ========================================== Files 532 535 +3 Lines 49727 49852 +125 ========================================== + Hits 27752 27910 +158 + Misses 18436 18371 -65 - Partials 3539 3571 +32 ``` | [Flag](https://app.codecov.io/gh/kubewharf/katalyst-core/pull/579/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf) | Coverage Δ | | |---|---|---| | [unittest](https://app.codecov.io/gh/kubewharf/katalyst-core/pull/579/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf) | `55.98% <71.73%> (+0.17%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

h-w-chen commented 3 weeks ago

no need to keep it any more.