search

kubewharf / katalyst-core

Katalyst aims to provide a universal solution to help improve resource utilization and optimize the overall costs in the cloud. This is the core components in Katalyst system, including multiple agents and centralized components
Apache License 2.0
388 stars 91 forks source link

refine metric-fetcher to support specified collecting intervals #581

Closed waynepeking348 closed 1 month ago

waynepeking348 commented 1 month ago

What type of PR is this?

enhancements

What this PR does / why we need it:

refine metric-fetcher to support specified collecting intervals

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 79.79798% with 20 lines in your changes are missing coverage. Please review.

Project coverage is 56.16%. Comparing base (4391efa) to head (b5d4258). Report is 1 commits behind head on main.

Files Patch % Lines
...md/katalyst-agent/app/options/metaserver/metric.go 57.57% 13 Missing and 1 partial :warning:
...atalyst-agent/app/options/metaserver/metaserver.go 25.00% 2 Missing and 1 partial :warning:
pkg/metaserver/agent/metric/metric_impl.go 95.16% 1 Missing and 2 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #581 +/- ## ========================================== + Coverage 55.87% 56.16% +0.28% ========================================== Files 533 534 +1 Lines 49730 49807 +77 ========================================== + Hits 27789 27973 +184 + Misses 18382 18269 -113 - Partials 3559 3565 +6 ``` | [Flag](https://app.codecov.io/gh/kubewharf/katalyst-core/pull/581/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf) | Coverage Δ | | |---|---|---| | [unittest](https://app.codecov.io/gh/kubewharf/katalyst-core/pull/581/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf) | `56.16% <79.79%> (+0.28%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.