search

kubewharf / katalyst-core

Katalyst aims to provide a universal solution to help improve resource utilization and optimize the overall costs in the cloud. This is the core components in Katalyst system, including multiple agents and centralized components
Apache License 2.0
388 stars 91 forks source link

add memory limit plugin for memory advisor #583

Open cccaoke opened 1 month ago

cccaoke commented 1 month ago

What type of PR is this?

What this PR does / why we need it:

add memory limit for reclaimed pods which set the limit in container spec

Which issue(s) this PR fixes:

Special notes for your reviewer:

CLAassistant commented 1 month ago

CLA assistant check
All committers have signed the CLA.

cccaoke commented 1 month ago

cc @WangZzzhe

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 73.07692% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 56.20%. Comparing base (74b648c) to head (8c3eeeb). Report is 2 commits behind head on main.

Files Patch % Lines
...in/qosaware/resource/memory/plugin/memory_limit.go 72.54% 9 Missing and 5 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #583 +/- ## ========================================== + Coverage 56.06% 56.20% +0.14% ========================================== Files 534 536 +2 Lines 49807 49881 +74 ========================================== + Hits 27924 28037 +113 + Misses 18325 18269 -56 - Partials 3558 3575 +17 ``` | [Flag](https://app.codecov.io/gh/kubewharf/katalyst-core/pull/583/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf) | Coverage Δ | | |---|---|---| | [unittest](https://app.codecov.io/gh/kubewharf/katalyst-core/pull/583/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf) | `56.20% <73.07%> (+0.14%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.