search

kubewharf / katalyst-core

Katalyst aims to provide a universal solution to help improve resource utilization and optimize the overall costs in the cloud. This is the core components in Katalyst system, including multiple agents and centralized components
Apache License 2.0
388 stars 91 forks source link

make malachite server port configurable #584

Open cccaoke opened 1 month ago

cccaoke commented 1 month ago

What type of PR is this?

Enhancements

What this PR does / why we need it:

malachite metrics provisoner using default port(9002) that may be used by others, by overriding the Rocket config file, but not katalyst.

Which issue(s) this PR fixes:

make malachite server port configurable

Special notes for your reviewer:

CLAassistant commented 1 month ago

CLA assistant check
All committers have signed the CLA.

cccaoke commented 1 month ago

cc @WangZzzhe @caohe

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 56.18%. Comparing base (5e1814b) to head (124c5b0). Report is 1 commits behind head on main.

Files Patch % Lines
...md/katalyst-agent/app/options/metaserver/metric.go 75.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #584 +/- ## ========================================== + Coverage 56.14% 56.18% +0.03% ========================================== Files 535 535 Lines 49865 49874 +9 ========================================== + Hits 27997 28022 +25 + Misses 18307 18283 -24 - Partials 3561 3569 +8 ``` | [Flag](https://app.codecov.io/gh/kubewharf/katalyst-core/pull/584/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf) | Coverage Δ | | |---|---|---| | [unittest](https://app.codecov.io/gh/kubewharf/katalyst-core/pull/584/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf) | `56.18% <81.81%> (+0.03%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

cccaoke commented 1 month ago

the conflict has been resolved，pls take a look @waynepeking348 @nightmeng