search

kubewharf / katalyst-core

Katalyst aims to provide a universal solution to help improve resource utilization and optimize the overall costs in the cloud. This is the core components in Katalyst system, including multiple agents and centralized components
Apache License 2.0
420 stars 103 forks source link

fix: convert memory by quantity.Value in overcommit controller #588

Closed WangZzzhe closed 4 months ago

WangZzzhe commented 4 months ago

What type of PR is this?

Bug fixes

What this PR does / why we need it:

Memory value overflow when node patch a large memory allocatable in status, eg. '1Ei'. Convert memory value by quantity.Value which can cover larger values than MilliValue.

Which issue(s) this PR fixes:

Special notes for your reviewer:

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 56.16%. Comparing base (74b648c) to head (6dbc70d). Report is 3 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #588 +/- ## ========================================== + Coverage 56.06% 56.16% +0.10% ========================================== Files 534 535 +1 Lines 49807 49831 +24 ========================================== + Hits 27924 27988 +64 + Misses 18325 18292 -33 + Partials 3558 3551 -7 ``` | [Flag](https://app.codecov.io/gh/kubewharf/katalyst-core/pull/588/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf) | Coverage Δ | | |---|---|---| | [unittest](https://app.codecov.io/gh/kubewharf/katalyst-core/pull/588/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf) | `56.16% <100.00%> (+0.10%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.