search

kubewharf / katalyst-core

Katalyst aims to provide a universal solution to help improve resource utilization and optimize the overall costs in the cloud. This is the core components in Katalyst system, including multiple agents and centralized components
Apache License 2.0
388 stars 91 forks source link

refine vpa apply strategy #590

Closed luomingmeng closed 1 month ago

luomingmeng commented 1 month ago

What type of PR is this?

Enhancements

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 65.45455% with 19 lines in your changes are missing coverage. Please review.

Project coverage is 55.93%. Comparing base (74b648c) to head (e61182c). Report is 3 commits behind head on main.

Files Patch % Lines
pkg/util/native/resources.go 0.00% 10 Missing :warning:
pkg/controller/vpa/vpa_status.go 42.85% 3 Missing and 1 partial :warning:
pkg/controller/vpa/util/resource.go 91.66% 2 Missing and 1 partial :warning:
pkg/controller/vpa/vpa.go 0.00% 1 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #590 +/- ## ========================================== - Coverage 56.06% 55.93% -0.13% ========================================== Files 534 535 +1 Lines 49807 49867 +60 ========================================== - Hits 27924 27895 -29 - Misses 18325 18416 +91 + Partials 3558 3556 -2 ``` | [Flag](https://app.codecov.io/gh/kubewharf/katalyst-core/pull/590/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf) | Coverage Δ | | |---|---|---| | [unittest](https://app.codecov.io/gh/kubewharf/katalyst-core/pull/590/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf) | `55.93% <65.45%> (-0.13%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.