codecov[bot]
commented
1 month ago Codecov Report
Attention: Patch coverage is 72.00000% with 7 lines in your changes are missing coverage. Please review.
Project coverage is 56.22%. Comparing base (
74b648c) to head (a666b97). Report is 5 commits behind head on main.
| Files | Patch % | Lines |
|---|---|---|
| ...minqos/reclaimedresource/reclaimedresource_base.go | 55.55% | 3 Missing and 1 partial :warning: |
| ...ce/memory/plugin/provisioner/memory_provisioner.go | 0.00% | 3 Missing :warning: |
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #592 +/- ## ========================================== + Coverage 56.06% 56.22% +0.15% ========================================== Files 534 535 +1 Lines 49807 49883 +76 ========================================== + Hits 27924 28045 +121 + Misses 18325 18268 -57 - Partials 3558 3570 +12 ``` | [Flag](https://app.codecov.io/gh/kubewharf/katalyst-core/pull/592/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf) | Coverage Δ | | |---|---|---| | [unittest](https://app.codecov.io/gh/kubewharf/katalyst-core/pull/592/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf) | `56.22% <72.00%> (+0.15%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf#carryforward-flags-in-the-pull-request-comment) to find out more.:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
What type of PR is this?
Enhancements
What this PR does / why we need it:
Add parameter MaxNodeUtilizationPercent，which will be converted to reservedForAllocated to limit the total amount of reclaimed resources.
PR should be updated after https://github.com/kubewharf/katalyst-api/pull/85 is merged