search

kubewharf / katalyst-core

Katalyst aims to provide a universal solution to help improve resource utilization and optimize the overall costs in the cloud. This is the core components in Katalyst system, including multiple agents and centralized components
Apache License 2.0
389 stars 91 forks source link

feat(qrm): implement allowing share_cores cpuset overlap with reclaimed_cores #597

Closed csfldf closed 1 day ago

csfldf commented 1 month ago

feat(qrm): use state to cache AllowSharedCoresOverlapReclaimedCores

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 60.54422% with 58 lines in your changes missing coverage. Please review.

Project coverage is 56.75%. Comparing base (7e559fd) to head (c18e309).

Files Patch % Lines
...ns/cpu/dynamicpolicy/policy_allocation_handlers.go 56.71% 22 Missing and 7 partials :warning:
...ins/cpu/dynamicpolicy/calculator/cpu_assignment.go 47.05% 16 Missing and 2 partials :warning:
...dynamic/adminqos/eviction/cpu_pressure_eviction.go 33.33% 4 Missing :warning:
...lugins/cpu/dynamicpolicy/policy_advisor_handler.go 20.00% 3 Missing and 1 partial :warning:
...lugins/cpu/dynamicpolicy/state/state_checkpoint.go 78.57% 2 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #597 +/- ## ========================================== - Coverage 56.89% 56.75% -0.15% ========================================== Files 544 544 Lines 51682 51807 +125 ========================================== - Hits 29407 29403 -4 - Misses 18570 18692 +122 - Partials 3705 3712 +7 ``` | [Flag](https://app.codecov.io/gh/kubewharf/katalyst-core/pull/597/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf) | Coverage Δ | | |---|---|---| | [unittest](https://app.codecov.io/gh/kubewharf/katalyst-core/pull/597/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf) | `56.75% <60.54%> (-0.15%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubewharf#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.